-
Notifications
You must be signed in to change notification settings - Fork 9
Add neural network modules, tests, and test utils #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
thisac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have yet to look at tests. Would this fit better in an nn folder, allowing more torch modules to be further organized into their own files. Can still be kept under the torch.nn namespace.
VolodyaCO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question about SkipLinear
anahitamansouri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much Kevin for the great work. I have left my comments.
|
RE @thisac : restructured the file into (sub)modules by pattern-matching pytorch's structure. |
anahitamansouri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much Kevin for addressing the comments.
thisac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kevinchern. I feel like the tests/utils and its tests could be somewhat simplified, and maybe cut down a bit, otherwise nothing major.
Co-authored-by: Theodor Isacsson <[email protected]>
|
RE @thisac : addressed most comments and left some clarifying questions in comments |
|
@thisac updated again based on your feedback on best practices. Thanks!!
|
| from tests import helper_functions | ||
|
|
||
|
|
||
| class TestUtils(unittest.TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| class TestUtils(unittest.TestCase): | |
| class TestHelperFunctions(unittest.TestCase): |
| ) | ||
|
|
||
| def forward(self, x: torch.Tensor) -> torch.Tensor: | ||
| """Transforms the input `x` with the modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| """Transforms the input `x` with the modules. | |
| """Transforms the input ``x`` with the modules. |
No description provided.