-
Notifications
You must be signed in to change notification settings - Fork 64
Automate autosummary documentation (WIP) #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Automate autosummary documentation (WIP) #585
Conversation
dc6fcd1 to
23bd2f7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #585 +/- ##
==========================================
- Coverage 89.38% 86.93% -2.46%
==========================================
Files 22 22
Lines 1997 1997
==========================================
- Hits 1785 1736 -49
- Misses 212 261 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit concerned about the maintenance of the template files. If/when we find some edge case then we'll have to update them in each repo. But probably that is net less maintenance than keeping all of the various autosummarys up to date. So seems reasonable to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and feels much better IMO.
I am a bit concerned about the maintenance of the template files. If/when we find some edge case then we'll have to update them in each repo.
I was also thinking about this. Although, I suppose the SDK templates would be the only ones needed for the published docs (no?), not to say that we shouldn't keep the local builds working as well.
|
I use the local builds myself frequently to test docs. So I think it needs to function in each individual repo, which means copying this file everywhere. I'll also say that IMO a better approach would be to modify I also think we could use vanilla Also, we discovered in the dwave-optimization PR that this approach doesn't handle aliases. Which seems like it may be a problem. 🤷 |
23bd2f7 to
9a44ff5
Compare
Note that if you try the Without some updates to templates or code (changing the sphinx autosummary code is not simple at all) the best we can do, as far as I can tell, is to use the default Let me know what you think. I do think our top priority is missed functions. If the rendering shown above is acceptable as a automated-docs halfhouse, might be worth a PR for the upcoming SDK. |
Main points:
This is an incomplete PR to get early reviews on the mechanism and if we want to proceed. If yes, I'll improve it before the final PR for review. So expect some rough edges and leave those for the final PR. I'm also opening another for a wider picture: dwave-optimization.