Add ListboxInput component for selecting multiple options and use it for barbuddies #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying outsite-nl with
|
| Latest commit: |
b7cc50e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://abb4a09e.dwhdelft-nl.pages.dev |
| Branch Preview URL: | https://features-multibuddy.dwhdelft-nl.pages.dev |
casperboone
reviewed
Apr 13, 2024
| @@ -12,19 +12,23 @@ const props = defineProps({ | |||
| barBuddies: { type: Array, required: true }, | |||
| }) | |||
|
|
|||
| const form = useReMemberForm('barbuddy', { | |||
| const form = useReMemberForm('barbuddy2', { | |||
There was a problem hiding this comment.
hm, I forgot, why can't we use the old form still?
Since we're just comma seperating the bar buddies I think we could just as well stick them into the original barbuddy property
casperboone
reviewed
Apr 13, 2024
| remarks: '', | ||
| }) | ||
|
|
||
| const formElement = ref(null) | ||
| const submit = async () => { | ||
| if (form.fields.buddies.length > 0) { | ||
| form.fields.buddy_preferences = form.fields.buddies.join(', ') | ||
| } | ||
| await form.submit() |
There was a problem hiding this comment.
Suggested change
| await form.submit() | |
| await form.submit({ | |
| buddy_preferences: form.fields.buddies.join(', ') || 'no_preference' | |
| }) |
I'd do something like this and remove the previous 3 lines + the property on line 22
casperboone
reviewed
Apr 13, 2024
There was a problem hiding this comment.
nice, still surprised this works, awesome
casperboone
reviewed
Apr 13, 2024
Comment on lines
+5
to
+7
| ListboxLabel, | ||
| ListboxButton, | ||
| ListboxOptions, |
There was a problem hiding this comment.
(and the ref import as well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.