Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counsellor bios and images #603

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Add counsellor bios and images #603

merged 3 commits into from
Aug 30, 2024

Conversation

casperboone
Copy link
Member

@casperboone casperboone commented Aug 25, 2024

Desktop:
image

Mobile:
image

Board pronouns als bonus ook toegevoegd

Closes #554

Copy link

cloudflare-workers-and-pages bot commented Aug 25, 2024

Deploying dwhdelft-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76eb5a9
Status:⚡️  Build in progress...

View logs

Copy link

cloudflare-workers-and-pages bot commented Aug 25, 2024

Deploying outsite-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76eb5a9
Status: ✅  Deploy successful!
Preview URL: https://26058d9c.dwhdelft-nl.pages.dev
Branch Preview URL: https://vcp.dwhdelft-nl.pages.dev

View logs

@thomcsmits
Copy link
Collaborator

I think their idea was to have this an expandable thing, so that you would only see the extra text when clicking on 'read more' or something, but this looks good to me as well.

Can we change the cut-off size for the 'mobile' display for this page only? Right now, just before the cut-off, the pictures are very narrow and don't look very good.

screenshot of display where peoples image are very narrow

@casperboone
Copy link
Member Author

  • That behavior got a bit complicated with the photos and everything, so I decided to keep it simple.

  • Good catch, fixed!

@casperboone casperboone merged commit e33ae17 into main Aug 30, 2024
2 of 3 checks passed
@casperboone casperboone deleted the vcp branch August 30, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add component where on click on person, detail text appears (for VCP's)
2 participants