Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newsletter to footer #622

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

thomcsmits
Copy link
Collaborator

No description provided.

Copy link

Deploying outsite-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: dda3de4
Status: ✅  Deploy successful!
Preview URL: https://2a2e3dc1.dwhdelft-nl.pages.dev
Branch Preview URL: https://thomcsmits-add-newsletter-to.dwhdelft-nl.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Oct 30, 2024

Deploying dwhdelft-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: dda3de4
Status:🚫  Build failed.

View logs

@laurensWe laurensWe marked this pull request as ready for review October 31, 2024 18:06
Copy link
Member

@laurensWe laurensWe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casperboone
Copy link
Member

Totally fine for now, in the past we also used to have a cool signup form on the site. Would be nice to reintroduce that at some point as well (#597 was tracking that)

@casperboone casperboone merged commit 5086c49 into main Oct 31, 2024
2 of 3 checks passed
@casperboone casperboone deleted the thomcsmits/add-newsletter-to-footer branch October 31, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants