Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Release new version with "type": "module" & .js -> .cjs #510

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jan 28, 2025

This PR releases a new version of the package to conform to the latest eslint requirements. #508 + #509
No library code was changed therefore there should not be any breaking changes downstream.
But we are releasing it as a new major version just-in-case the "type": "module" breaks anything
and we don't end up taking down someone's app/site. 💭

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3606c07) to head (c9478e0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #510   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          155       155           
  Branches        45        45           
=========================================
  Hits           155       155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nelsonic nelsonic changed the title PR: Release new version with "type": "module" and .js -> .cjs #509 PR: Release new version with "type": "module" & .js -> .cjs Jan 28, 2025
@nelsonic
Copy link
Member Author

hapi-auth-jwt2@11.0.0 on NPM: https://www.npmjs.com/package/hapi-auth-jwt2/v/11.0.0

Copy link
Member

@asntc asntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit:

@asntc asntc merged commit 6447e7c into main Jan 28, 2025
6 checks passed
@asntc asntc deleted the release-new-version-with-cjs-#509 branch January 28, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants