Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Migrate to v3 #16

Merged
merged 34 commits into from
Oct 14, 2024
Merged

[PR] Migrate to v3 #16

merged 34 commits into from
Oct 14, 2024

Conversation

LuchoTurtle
Copy link
Member

@LuchoTurtle LuchoTurtle commented Oct 14, 2024

closes #15

This PR migrates this package to v3. It:

  • removes contentlayer2 and switches to remark. Links are now validated with remark-validate-links
  • updates the theme
  • updates the src folder according to the migration guide at https://the-guild.dev/blog/nextra-3.
  • updates dependencies
  • removes unnecessary/unused files.
  • updated the README and tutorial.md to add instances of the difference between versions.

@LuchoTurtle LuchoTurtle added in-progress An issue or pull request that is being worked on by the assigned person chore a tedious but necessary task often paying technical debt labels Oct 14, 2024
@LuchoTurtle LuchoTurtle self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (322f93e) to head (4f05979).
Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #16    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         4     +1     
  Lines          211        69   -142     
  Branches        30         1    -29     
==========================================
- Hits           211        69   -142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Oct 14, 2024
@LuchoTurtle LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Oct 14, 2024
@LuchoTurtle
Copy link
Member Author

@nelsonic this should be mergeable. The bottleneck was contentlayer2, which was replaced with our linting strategy in the A docs repo. I've documented both strategies in the tutorial.md file.

@nelsonic nelsonic added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Oct 14, 2024
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle looks good. 👌

@nelsonic nelsonic merged commit 9370efd into main Oct 14, 2024
3 checks passed
@nelsonic nelsonic deleted the v3 branch October 14, 2024 15:33
@nelsonic
Copy link
Member

Especially like that this PR has a net removal of lines from the project. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nextra V3
2 participants