Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure when PR is behind main #10

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

trask
Copy link
Contributor

@trask trask commented Jan 13, 2022

I think will resolve #8 (we are also seeing this in opentelemetry-java-contrib.

Follows same fix as jitterbit/get-changed-files#11 (comment)

@dyladan
Copy link
Owner

dyladan commented Jan 13, 2022

Interesting. I just put that in there as a sanity check/guard to make sure that i was getting the right commits, but i guess its actually causing issues haha. in any case it doesn't serve any real useful purpose and i've never seen it triggered for a legit problem so removing it should be fine.

@dyladan dyladan merged commit c243152 into dyladan:main Jan 13, 2022
@trask trask mentioned this pull request Jan 13, 2022
@trask trask deleted the fix-failure-when-pr-is-behind-main branch October 25, 2022 03:44
trask added a commit to trask/assign-reviewers-action that referenced this pull request Apr 11, 2023
dyladan added a commit to open-telemetry/assign-reviewers-action that referenced this pull request Apr 11, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component Owners action error when a commit is ammended
2 participants