Dispatch profiling #1621
Merged
Dispatch profiling #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sources/lib/dispatch-profiler/dispatch-profiler.dylan (print-dispatch-statistics): Remove a whitespace-stripping workaround for a problem with the pentium-dw command parser.
* sources/dfmc/modeling/functions.dylan (&class <profiling-call-site-cache-header-engine-node>): Declare the count slots for profiling cache-header engine nodes as <raw-machine-word> to reflect the way they are used in generated code. * sources/dfmc/llvm-back-end/llvm-entry-points.dylan (entry-point-descriptor profiling-cache-header): Remove a "todo" comment about making the change above.
* sources/dylan/discrimination.dylan (compute-terminal-engine-node): Change the initialization order of profiling cache header engine nodes so that the generic function is available to the primitive-initialize-engine-node implementation (via the cache-header-engine-node-parent slot).
* sources/dylan/new-dispatch.dylan (make-linear-class-keyed-discriminator): Initialize lckd-hits in newly instantiated <linear-class-keyed-discriminator> nodes. (linear-class-key-lookup): Increment lckd-hits when the class is found. (make-linear-singleton-discriminator): Initialize lsd-hits in newly instantiated <linear-singleton-discriminator> nodes. (immediate-linear-singleton-discriminator-element): Increment lsd-hits when the matching instance is found. (value-object-linear-singleton-discriminator-element): Increment lsd-hits when the matching instance is found.
* sources/lib/dispatch-profiler/dispatch-profiler.dylan (with-dispatch-profiling-report): New macro for performing dynamic dispatch profiling on a block of code and printing out a summary report after execution completes. * sources/lib/dispatch-profiler/dispatch-profiler-library.dylan (module dispatch-profiler): Export the with-dispatch-profiling-report macro.
cgay
requested changes
Jun 23, 2024
documentation/source/library-reference/dispatch-profiler/index.rst
Outdated
Show resolved
Hide resolved
* documentation/source/library-reference/dispatch-profiler/index.rst: New documentation source. * documentation/source/library-reference/index.rst: Add the dispatch-profiler to the Library Reference.
* sources/lib/dispatch-profiler/walk-dispatch.dylan (with-preserved-dispatch-walking-types): Comment out this currently unused macro definition.
housel
force-pushed
the
dispatch-profiling-arcana
branch
from
1aa5350
to
114b29c
Compare
cgay
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix dispatch profiling, make it more usable in practice, and document how to use it.