fix(db): amend add_content path_string and device #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcork
commented
Jul 7, 2024
tjcork
commented
- path_string: When adding a track, on windows seems path_string needs to be in posix format
- device: The first device is not always the one desired, allow Device= to be passed in kwargs
1. path_string: When adding a track, on windows seems path_string needs to be in posix format 2. device: The first device is not always the one desired, allow Device=<device> to be passed in kwargs
…a playlists tracks instead of one by one
…er wants to override the running rekordbox setting
|
Hey @tjcork, thank you for contributing! If I remember correctly, the paths in the DB are platform specific! However, Rekordbox doesn't care, so we could just use POSIX paths as you suggested. The method you added for the track numbers is nice, too. Same for the device, thanks for fixing this:) However, I have some strong thoughts about poetry. I do not want to switch build systems, and I personally don't like poetry. They have done some questionable stuff in the past (added flaky bugs on purpose), so I really think we should leave the current build system in place. What issues are you having in poetry environments? I would happily merge your PR if you revert the changes to the build system! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.