feat: check min amount and warn only when necessary#1411
Open
anhductn2001 wants to merge 2 commits intomainfrom
Open
feat: check min amount and warn only when necessary#1411anhductn2001 wants to merge 2 commits intomainfrom
anhductn2001 wants to merge 2 commits intomainfrom
Conversation
artemijspavlovs
requested changes
Nov 27, 2025
Collaborator
artemijspavlovs
left a comment
artemijspavlovs
left a comment
There was a problem hiding this comment.
a similar check should also happen during service restarts since this would appear in systemd logs but the user wouldn't see them
|
|
||
| warnErr := sequencerutils.WarnIfSequencerBelowLivenessSlashMin(rollappConfig) | ||
| if warnErr != nil { | ||
| pterm.Warning.Println("failed to evaluate liveness slash minimum:", warnErr) |
Collaborator
There was a problem hiding this comment.
it doesn't fail to evaluate, it evaluates and answers, no?
artemijspavlovs
requested changes
Dec 15, 2025
|
|
||
| warnErr := sequencerutils.WarnIfSequencerBelowLivenessSlashMin(rollappConfig) | ||
| if warnErr != nil { | ||
| pterm.Warning.Println("failed to evaluate liveness slash minimum:", warnErr) |
Collaborator
There was a problem hiding this comment.
it doesn't fail to evaluate, it evaluates and answers, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
For Author:
godoccommentsFor Reviewer:
After reviewer approval: