Skip to content

Commit

Permalink
change to streamlit query params due to upgrade
Browse files Browse the repository at this point in the history
  • Loading branch information
Markus Gierlinger committed Jan 15, 2024
1 parent d397466 commit db0c6ad
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 13 deletions.
3 changes: 1 addition & 2 deletions kalm_benchmark/ui/_pages/overview.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,7 @@ def show() -> None:
tool_name = selection["name"]
if st.button(f"Show Details for {tool_name}"):
# trigger navigation by setting page query parameter and reloading the page
params = {QueryParam.Page: Page.Scanner, QueryParam.SelectedScanner: tool_name}
st.experimental_set_query_params(**params)
st.query_params = {QueryParam.Page: Page.Scanner, QueryParam.SelectedScanner: tool_name}
# wait a bit to ensure the query params are properly updated
# because the rerun is triggered via an exception that stops everything
time.sleep(0.2)
Expand Down
4 changes: 1 addition & 3 deletions kalm_benchmark/ui/_pages/scanner_details.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ def show() -> None:
key = "scanner"

def _on_change():
params = st.experimental_get_query_params()
params[QueryParam.SelectedScanner] = st.session_state[key]
st.experimental_set_query_params(**params)
st.query_params[QueryParam.SelectedScanner] = st.session_state[key]

scanners = list(SCANNERS.keys())
# if specified, use tool from query parameter as default selection
Expand Down
4 changes: 1 addition & 3 deletions kalm_benchmark/ui/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ def show_page_navigation() -> Page:
key = "navigation"

def _on_page_change():
params = st.experimental_get_query_params()
params[QueryParam.Page] = st.session_state[key]
st.experimental_set_query_params(**params)
st.query_params[QueryParam.Page] = st.session_state[key]

# if specified, use page query parameter as initial selection
initial_page = get_query_param(QueryParam.Page, pages[0])
Expand Down
8 changes: 3 additions & 5 deletions kalm_benchmark/ui/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,10 @@ def get_query_param(param: str, default: str | None = None) -> str | None:
:param default: the default value if the parameter is not set, defaults to None
:return: the value of the specified query parameter or the default value if parameter is not set
"""
query_params = st.experimental_get_query_params()
param_values = query_params.get(param, {})
if len(param_values) > 0:
return param_values[0]
else:
param_values = st.query_params.get(param, None)
if param_values is None:
return default
return param_values


def get_selected_result_file(tool_name: str) -> str:
Expand Down

0 comments on commit db0c6ad

Please sign in to comment.