Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64 missing libatomic #112

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

karczex
Copy link

@karczex karczex commented Nov 12, 2024

No description provided.

@dynatrace-cla-bot
Copy link
Member

dynatrace-cla-bot commented Nov 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

It's attempt to not include redundant headers
@karczex karczex force-pushed the arm64-missing-libatomic branch from d9ac912 to 7d09c78 Compare November 19, 2024 16:06
Original motivation for this change was to
remove unnecessary binary dependency on
libatomic. As it appeared source of this dependency
was protobuf. As this quite complex piece of
software was used only to generate simple json
I swiched it to boost::json.
I decided to use boost::json because boost already was
dependency for eBPF discovery.
@karczex karczex force-pushed the arm64-missing-libatomic branch from 7d09c78 to 38e2d55 Compare November 19, 2024 17:00
@pawsten
Copy link
Collaborator

pawsten commented Nov 26, 2024

Is this PR ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants