Arm64 missing libatomic #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
karczex
force-pushed
the
arm64-missing-libatomic
branch
2 times, most recently
from
7d09c78 to
38e2d55
Compare
|
Is this PR ready? |
It's attempt to not include redundant headers
karczex
force-pushed
the
arm64-missing-libatomic
branch
2 times, most recently
from
3460f2f to
015453f
Compare
karczex
force-pushed
the
arm64-missing-libatomic
branch
from
7af2224 to
020b138
Compare
marudno
reviewed
Dec 19, 2024
|
|
||
| namespace boost::json::ext { | ||
|
|
||
| void print(std::ostream& os, boost::json::value const& jv) { |
There was a problem hiding this comment.
consider moving const at the beginning: "const boost::json::value&"
karczex
force-pushed
the
arm64-missing-libatomic
branch
from
020b138 to
ff2950e
Compare
filip-szweda
previously approved these changes
Dec 20, 2024
karczex
force-pushed
the
arm64-missing-libatomic
branch
from
ff2950e to
1a64aa3
Compare
Original motivation for this change was to remove unnecessary binary dependency on libatomic. As it appeared source of this dependency was protobuf. As this quite complex piece of software was used only to generate simple json I swiched it to boost::json. I decided to use boost::json because boost already was dependency for eBPF discovery.
Setting base image to fixed version should stabilise cppcheck CI job. If we use latest tag, cppcheck package major version would be updateded at some point. This follows to failures on CI in not related parts of the code. This version should be updateded at some point.
karczex
force-pushed
the
arm64-missing-libatomic
branch
from
1a64aa3 to
da16ec7
Compare
filip-szweda
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.