Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default chunk size limit override #50

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Apr 30, 2024

Removes the chunk size limit override we were previously applying. Fluent already has good default values and tuning for specific cases and performance is well covered in their docs.

Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyladan
Copy link
Member Author

dyladan commented Apr 30, 2024

Buffer configuration options are here: https://docs.fluentd.org/configuration/buffer-section

Most of the time what you actually want is flush_interval to achieve what we were previously achieving by limiting the chunk size.

@dyladan dyladan enabled auto-merge (squash) May 21, 2024 18:44
@dyladan dyladan disabled auto-merge May 21, 2024 18:44
@arminru arminru requested a review from a team May 22, 2024 15:41
@dyladan dyladan merged commit 9e6594e into main Jun 14, 2024
13 checks passed
@dyladan dyladan deleted the no-chunk-limit-default-override branch June 14, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants