feat(core): separate open() and connect() constructors

I thought it is nicer since we also have getOpen() and getConnect() (and fetch* variants).
dyne · Oct 17, 2023 · 32f99d8 · 32f99d8
1 parent b822da6
commit 32f99d8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/pkg/core/src/plugin.ts b/pkg/core/src/plugin.ts
@@ -248,10 +248,18 @@ export class PluginContextTest implements PluginContext {
 	/**
 	 * @constructor
 	 */
-	static openconnect(openconnect: string | string[]) {
-		return new this(openconnect, {});
+	static open(open: string | string[]) {
+		return new this(open, {});
 	}
 
+	/**
+	 * @constructor
+	 */
+	static connect(connect: string | string[]) {
+		return new this(connect, {});
+	}
+
+
 	/**
 	 * @constructor
 	 */

diff --git a/pkg/http/test/plugins.ts b/pkg/http/test/plugins.ts
@@ -40,7 +40,7 @@ test('Simple GET', async (t) => {
 		return;
 	}
 
-	const ctx = PluginContextTest.openconnect('http://localhost/normaljson');
+	const ctx = PluginContextTest.connect('http://localhost/normaljson');
 	const res = await execute(ctx, ast.kind, ast.method);
 	t.deepEqual(res, {
 		ok: true,