Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new zenroom validate api to search for ignored and invalid statements #134

Merged
merged 5 commits into from
May 22, 2024
Merged

feat: use new zenroom validate api to search for ignored and invalid statements #134

merged 5 commits into from
May 22, 2024

Conversation

matteo-cristino
Copy link
Collaborator

  • test: fix data type on zenroom given
  • feat(shared): import zenroom validate api
  • feat: use new zenroom validate api to search for ignored and invalid statements
  • chore: bump zenroom version to at least 4.31.2

@matteo-cristino
test: fix data type on zenroom given
e59a6bd 
Now if array is loaded as dictioanry, or viceversa, zenroom fails
@matteo-cristino
feat(shared): import zenroom validate api
bf8f871
@matteo-cristino
feat: use new zenroom validate api to search for ignored and invalid …
1de1135 
…statements

This is still a first draft, error on invlaid statement should be improved by suggesting to the user to use 'Rule unknown ignore' if not used already
@matteo-cristino
chore: bump zenroom version to at least 4.31.2
f637059 
This is needed since new zenroom valid api is working only from this version
@matteo-cristino
Copy link
Collaborator Author

TODO:

  • improve error reporting by creating anew class that extends Error for invalid statements
  • on invalid statement check if 'Rule unknown ignore' is present, if not, then suggest to the user to add it

@matteo-cristino matteo-cristino marked this pull request as draft May 16, 2024 15:10
@matteo-cristino
feat(ingored): on invalid statement understand if they can be ignored…
96d82b5 
… or not

This improve error messages on invalid statement that now suggest to the user to add Rule unknown ignore only when it can make the difference
@matteo-cristino matteo-cristino marked this pull request as ready for review May 22, 2024 10:39
@matteo-cristino matteo-cristino linked an issue May 22, 2024 that may be closed by this pull request
Slangroom error on mising Rule unknown ignore #131
Closed
@matteo-cristino matteo-cristino mentioned this pull request May 22, 2024
Merged
@puria puria requested a review from denizenging May 22, 2024 17:31
@puria puria merged commit 0ab23bd into main May 22, 2024
6 checks passed
@puria puria deleted the feat/missing_ignore branch May 22, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puria puria Awaiting requested review from puria

@denizenging denizenging Awaiting requested review from denizenging

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slangroom error on mising Rule unknown ignore
2 participants
@matteo-cristino @puria