Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oauth): new statements for authorization_details and request_uri #148

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

RebeccaSelvaggini
Copy link
Collaborator

@RebeccaSelvaggini RebeccaSelvaggini commented May 31, 2024

The first new statement looks like
Given I send request 'request' and send server_data 'server' and verify request parameters
given the parameters of an /authorize request, it checks the validity of the given request_uri and client_id in request.

The second statement looks like
Given I send request_uri 'request_uri' and send data 'data' and send server_data 'server' and add data to authorization_details and output into 'auth_details'
given a request_uri and a string dictionary data, it updates the authorization_details linked to the request_uri adding a new field claims that contains the dictionary data.

Copy link
Member

@puria puria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k for me let also @matteo-cristino to have a look

@matteo-cristino
Copy link
Collaborator

Seems good, the only thing that maybe I would change is the authorization_details by removing the underscore. We use it before since the parser can take only one word as parameter key, but in the statement identifier we do not have this problem and without the underscore it can be more readble and easier to remember (as also all the other statement indentifiers do not have underscore in this plugin)

@puria
Copy link
Member

puria commented May 31, 2024

Seems good, the only thing that maybe I would change is the authorization_details by removing the underscore. We use it before since the parser can take only one word as parameter key, but in the statement identifier we do not have this problem and without the underscore it can be more readble and easier to remember (as also all the other statement indentifiers do not have underscore in this plugin)

I just add that some documentation will be beneficial for everyone ;p and a little bit more testing

@matteo-cristino matteo-cristino merged commit eba9849 into main Jun 6, 2024
7 checks passed
@matteo-cristino matteo-cristino deleted the refactor/oauth branch June 6, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants