fix: use chalk to style error message insted of using directly ansi escape codes #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matteo-cristino
commented
Jun 3, 2024
matteo-cristino
commented
- chore: import chalk in @slangroom/deps and expose error coloring and formatting functions from @slagnroom/shared
- fix: use chalk to style error message insted of using directly ansi escape codes
…formatting functions from @slagnroom/shared In this way in the future we can easily have also colored error in the plugin
puria
approved these changes
Jun 9, 2024
|
is this ready? should I merge it @matteo-cristino |
|
I was not able to test it in some console without the color like the browser example that you did said on the issue, thus I don't know if this solve that issue. Other than that this should be ready 🥠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.