refactor(db): improve error reporting and code clean up #171

matteo-cristino · 2024-06-26T13:29:46Z

fix(db): do not hide real db errors and do not print databse in error since it can contains username and password
chore(db): add @slangroom/shared as dependency
refactor(db): improve error reporting
test(db): more failing test

… since it can contains username and password

Remove also some duplicated code

the message field of that error was an empty string

matteo-cristino added 4 commits June 25, 2024 18:20

fix(db): do not hide real db errors and do not print databse in error…

52795f0

… since it can contains username and password

chore(db): add @slangroom/shared as dependency

f21c783

refactor(db): improve error reporting

7d33c7f

Remove also some duplicated code

test(db): more failing test

850a1fe

matteo-cristino marked this pull request as draft June 26, 2024 14:26

fix(db): improve handling of connectionRefusedError error

bc19948

the message field of that error was an empty string

matteo-cristino marked this pull request as ready for review June 26, 2024 15:56

matteo-cristino added 2 commits June 26, 2024 19:06

fix(db): improve typing

a615238

test(db): refactor and remove some useless try...catch

a01fc58

matteo-cristino requested a review from puria June 28, 2024 14:42

puria merged commit 2c76af0 into main Jul 1, 2024
7 checks passed

puria deleted the fix/db_error branch July 1, 2024 07:57

Provide feedback