Sf/before plugin #22
Merged
Sf/before plugin #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zenroom might throw an exception when we're trying to get the list of ignored statements. This fixes that.
Now, the BeforePlugin class can optionally return a ZenroomParams that will be injected into the actual Zenroom execution.
Slangroom statement will be exectuted in the order they are written such that it is possible to use data from a previous computation. All slangroom statement should be written before (for given) or after (for then) the zenroom statements. This is because, at the moment, we cannot start executing zenroom and suspend its execution before each slangroom statement (maybe it will be possible with improvement on exportable heap in zenroom).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for BeforePlugins to inject variables into the actual Zenroom execution.