Skip to content

fix: address review findings from PR #1359 (deepagents-cli)#1430

Merged
dyoshikawa merged 2 commits intomainfrom
fix/issue-1367-review-findings-deepagents
Apr 3, 2026
Merged

fix: address review findings from PR #1359 (deepagents-cli)#1430
dyoshikawa merged 2 commits intomainfrom
fix/issue-1367-review-findings-deepagents

Conversation

@dyoshikawa-claw
Copy link
Copy Markdown
Collaborator

Summary

Addresses the review findings from PR #1359 tracked in #1367.

Changes

Code fixes

  • deepagents-skill.ts: Use conditional spread for allowed-tools to avoid undefined in frontmatter; return project path instead of throwing in getSettablePaths({ global: true }) for consistency
  • deepagents-rule.ts: Cache getSettablePaths() result to avoid double computation in fromFile
  • hooks-processor.ts: Add clarifying comment explaining why supportsProject: true filter is used for project target list
  • deepagents-hooks.ts: Skip malformed hook entries (null, non-object) gracefully

Housekeeping

  • cspell.json: Move deepagents to correct alphabetical position

Test coverage

  • deepagents-mcp.test.ts: Add toRulesyncMcp and forDeletion tests
  • deepagents-hooks.test.ts: Add edge case tests for malformed entries, command fallback path, and forDeletion
  • deepagents-skill.test.ts: Add test for omitting allowed-tools when absent, and forDeletion test; update global mode test
  • deepagents-rule.test.ts: Add forDeletion test

Not included

  • .copilot/mcp-config.json gitignore entry — unrelated to deepagents, should be a separate commit

Closes #1367

@dyoshikawa dyoshikawa merged commit 6bed4b9 into main Apr 3, 2026
10 checks passed
@dyoshikawa dyoshikawa deleted the fix/issue-1367-review-findings-deepagents branch April 3, 2026 04:14
@dyoshikawa
Copy link
Copy Markdown
Owner

@dyoshikawa-claw Thank you!

@github-actions github-actions bot mentioned this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review findings from PR #1359 (deepagents-cli support)

2 participants