fix: address review findings from PR #1359 (deepagents-cli)#1430
Merged
dyoshikawa merged 2 commits intomainfrom Apr 3, 2026
Merged
fix: address review findings from PR #1359 (deepagents-cli)#1430dyoshikawa merged 2 commits intomainfrom
dyoshikawa merged 2 commits intomainfrom
Conversation
Owner
|
@dyoshikawa-claw Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the review findings from PR #1359 tracked in #1367.
Changes
Code fixes
allowed-toolsto avoidundefinedin frontmatter; return project path instead of throwing ingetSettablePaths({ global: true })for consistencygetSettablePaths()result to avoid double computation infromFilesupportsProject: truefilter is used for project target listHousekeeping
deepagentsto correct alphabetical positionTest coverage
deepagents-mcp.test.ts: AddtoRulesyncMcpandforDeletiontestsdeepagents-hooks.test.ts: Add edge case tests for malformed entries, command fallback path, andforDeletiondeepagents-skill.test.ts: Add test for omittingallowed-toolswhen absent, andforDeletiontest; update global mode testdeepagents-rule.test.ts: AddforDeletiontestNot included
.copilot/mcp-config.jsongitignore entry — unrelated to deepagents, should be a separate commitCloses #1367