fix: fail check mode when delete would remove orphan files#1436
Open
dyoshikawa-claw wants to merge 13 commits intomainfrom
Open
fix: fail check mode when delete would remove orphan files#1436dyoshikawa-claw wants to merge 13 commits intomainfrom
dyoshikawa-claw wants to merge 13 commits intomainfrom
Conversation
dyoshikawa
force-pushed
the
fix/issue-1431
branch
from
527b1f8 to
824216c
Compare
…esystem reads - Remove includeNonDeletable parameter from all processor interfaces and implementations since it was never called with true - Hoist loadToolFiles/loadToolDirsToDelete calls to avoid duplicate filesystem scans in check+delete mode - Remove redundant orphan check conditions subsumed by orphanCount logic Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ands/subagents empty handling Extract a shared helper to eliminate duplicated rulesyncFiles.length === 0 branching across generateRulesCore, generateIgnoreCore, generateMcpCore, and generateHooksCore. Also apply the same empty-rulesync handling to generateCommandsCore and generateSubagentsCore so check mode correctly detects delete-only diffs for those features. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
removeOrphanAiFiles/removeOrphanAiDirs already return orphan count in dry-run mode, making the manual Set+filter check unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #1431