feat(hooks): add Codex CLI hooks support#1439
Merged
dyoshikawa merged 9 commits intodyoshikawa:mainfrom Apr 6, 2026
Merged
Conversation
Closed
dyoshikawa
reviewed
Apr 4, 2026
Owner
dyoshikawa
left a comment
dyoshikawa
left a comment
There was a problem hiding this comment.
I like the direction here, but I found a few behavior issues that should be addressed before this is merged. The biggest problem is that generating Codex hooks now mutates .codex/config.toml directly, which bypasses the normal write flow and can change the worktree even during preview-style execution; there is also a mismatch where non-command hooks can still be emitted for codexcli even though the processor declares command-only support.
- Filter out non-command hook types in canonicalToCodexcliHooks to prevent invalid entries in Codex CLI output - Replace ensureCodexHooksFeatureFlag side-effect write with CodexcliConfigToml generated file that goes through the normal write pipeline, respecting dry-run mode - Add regression tests for prompt-type hook filtering and CodexcliConfigToml generation
Owner
|
@henriquemod Thank you! |
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.codex/hooks.jsonfrom unified rulesync hook definitionsCodexcliHooksclass with bidirectional conversion between canonical and Codex CLI hook formats (PascalCase event names, inline command format).codex/config.tomlwithcodex_hooks = truefeature flag when generating hooksChanges
src/types/hooks.tssrc/features/hooks/codexcli-hooks.tssrc/features/hooks/codexcli-hooks.test.tssrc/features/hooks/hooks-processor.tssrc/features/hooks/hooks-processor.test.tssrc/cli/commands/gitignore-entries.ts.codex/hooks.jsonpatternREADME.md,docs/,skills/.gitignore