Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This pull isn't merge-worthy quite yet, and I don't know that I'll come back to it tomorrow, but I wanted to be sure to leave what I have in case anyone else has any insights.
I first implemented this as shown on the guile_concise branch, and then again with a dedicated extension and the extra boilerplate needed to compile it, in the naive hope that would speed it up, but I just don't know what I'm doing :p
Here are the results I get (with the tool-chains that I bothered to setup, am on GuixSD):
Yeah, yikes, that can't be right. Maybe I'm measuring nanoseconds wrong? It went through a few drafts, but was always putting out a few figures more than I'd like., and really does take 10-15 seconds. I tried profiling it with
statprof, but it's all too far down inplusone. I could try enabling some extra compiler optimizations (defaults to level 2 out of 9)?What's missing:
.scmfiles on first-run, so it probably doesn't even need handled in the Tupfile for the concise branch. We could stick a shebang onguile/hello.scm,chmod +x, and simplify the call inrun-all.shto./gulie/hello.scm, too, but I'm not cleaning up until I've gotten to the bottom the order-of-magnitude speed difference I'm seeing.