Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with nextcloud 28 #39

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Boc-chi-no
Copy link
Contributor

#38 #26 Compatible with nextcloud 28
[U] Refactored project structure to adhere to PSR-4 standards
[U] Eliminated sudo usage for enhanced security

[U] Refactored project structure to adhere to PSR-4 standards
[U] Eliminated sudo usage for enhanced security
@farrad
Copy link

farrad commented Jul 29, 2024

@Boc-chi-no Thanks for your efforts to fix the compatibility issue!

I tested your fix and for me still the following Fatal error occurs:

    "File": "/var/www/html/custom_apps/scanner/lib/AppInfo/Application.php",
    "Line": 43,
    "message": "Error during app service registration: Call to undefined method OC\\Server::getEventDispatcher()",
    "exception": [],
    "CustomMessage": "Error during app service registration: Call to undefined method OC\\Server::getEventDispatcher()"

Do you think you could also adjust to the breaking change of the Event API in the NC28 ?

@Boc-chi-no
Copy link
Contributor Author

@Boc-chi-no Thanks for your efforts to fix the compatibility issue!

I tested your fix and for me still the following Fatal error occurs:

    "File": "/var/www/html/custom_apps/scanner/lib/AppInfo/Application.php",
    "Line": 43,
    "message": "Error during app service registration: Call to undefined method OC\\Server::getEventDispatcher()",
    "exception": [],
    "CustomMessage": "Error during app service registration: Call to undefined method OC\\Server::getEventDispatcher()"

Do you think you could also adjust to the breaking change of the Event API in the NC28 ?

Oh, I see the issue now. I might have mistakenly thought it was compatible with NC28 when it was actually for NC27. I'll update my server, then I'll look into this issue and make it compatible with NC28.

@farrad
Copy link

farrad commented Sep 12, 2024

See compatible version for Nextcloud 28 and 29 in this pull request.

Note it is NOT backward compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants