⬆️ 📌 ➕ Fix the build process #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was originally added in 4566cc0 and seems to work fine for the `serve` case But it doesn't work for the `cordovabuild` case e-mission/e-mission-docs#1113 (comment) e-mission/e-mission-docs#1113 (comment) Adding it, although I still don't know why the `serve` case did not need it
In the previous commit, 1089679 we copied over the cordovabuild package-lock from the internal build of NREL OpenPATH. However, when trying to get the internal build to complete, for this release, I moved out the existing package-lock and regenerated, as an attempt to fix e-mission/e-mission-docs#1113 (comment) After adding the new module (in b9e9a37) all of the dependency versions also changed. Since `package-lock.json` is supposed to represent the checked in "time travel" version of the modules actually used, we update this to reflect the current module versions used as well.
In #1193, I added `module:@react-native/babel-preset` That caused the unit tests to work, but caused a WSOD with the release build e-mission/e-mission-docs#1113 (comment) So we exclude the preset for production builds I tried to add it only to dev builds, but the `process.env.ENV` is not set correctly so I had to switch the condition e-mission/e-mission-docs#1113 (comment) Testing done: ``` $ npm run test Test Suites: 27 passed, 27 total Tests: 182 passed, 182 total Snapshots: 0 total Time: 10.537 s Ran all test suites. ```
shankari
force-pushed
the
force_package_dependencies_fix_tests
branch
from
4b7ca52 to
7429fff
Compare
…into force_package_dependencies_fix_tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
=======================================
Coverage 29.76% 29.76%
=======================================
Files 123 123
Lines 4959 4959
Branches 1143 1096 -47
=======================================
Hits 1476 1476
Misses 3483 3483
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several issues from e-mission/e-mission-docs#1113