Skip to content

Conversation

@ben-fornefeld
Copy link
Member

@ben-fornefeld ben-fornefeld commented Oct 29, 2025

Note

Adds sandbox kill actions (details header + list table), introduces confirmation popover, and refines sandbox info/metrics polling tied to running state.

  • Sandbox Details (Inspect):
    • Add KillButton with confirmation via AlertPopover; disabled when not running.
    • RefreshControl now shows 0s polling when sandbox not running.
    • Header layout updated to include Kill + Refresh controls.
  • Sandboxes List:
    • New actions column with dropdown to kill a running sandbox; shows loader and confirmation sub-menu.
    • Row link updated with passHref.
  • State/Data Fetching:
    • SandboxContext now tracks isRunningState and lastFallbackData.
    • SWR keys/requests switched from serverSandboxInfo to lastFallbackData.
    • Metrics polling and refresh interval dynamically pause when not running.
  • Server Actions:
    • New killSandboxAction to DELETE /sandboxes/{sandboxID} with auth; maps errors (404 → "Sandbox not found").
  • UI Components:
    • New AlertPopover primitive for confirm/cancel flows.

Written by Cursor Bugbot for commit d8a1473. This will update automatically on new commits. Configure here.

- Added kill button component to sandbox header for direct sandbox termination
- Added teamId prop to SandboxDetailsHeader for improved team context handling
- Modified polling behavior to stop when sandbox is not running
- Updated sandbox context to use lastFallbackData instead of serverSandboxInfo for more reliable state management
- Improved header layout with flexbox ordering for better mobile responsiveness

The changes focus
@vercel
Copy link

vercel bot commented Oct 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web Ready Ready Preview Comment Oct 30, 2025 1:19pm
web-juliett Ready Ready Preview Comment Oct 30, 2025 1:19pm

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@ValentaTomas
Copy link
Member

ValentaTomas commented Oct 29, 2025

  1. Would add the sandbox ID mention to the kill modal
  2. Or not have a whole modal, but just a small appearing confirmation window right under the clicked button, when you click kill. That seems way less intrusive.
  3. Thinking if we want the kill also on in the list of all sandboxes, under some "..." or just delete on the right side, to save a click.

@ben-fornefeld
Copy link
Member Author

  • Would add the sandbox ID mention to the kill modal
  • Or not have a whole modal, but just a small appearing confirmation window right under the clicked button, when you click kill. That seems way less intrusive.
  • Thinking if we want the kill also on in the list of all sandboxes, under some "..." or just delete on the right side, to save a click.

1./2. addressed by using popover and dropdown menu sub trigger.
3. implemented as well

cursor[bot]

This comment was marked as outdated.

@ben-fornefeld
Copy link
Member Author

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no bugs!


@ben-fornefeld
Copy link
Member Author

Thinking if we want the kill also on in the list of all sandboxes, under some "..." or just delete on the right side, to save a click.

we discovered weird race-conditions when removing sandboxes through the sandbox list. overall the sandboxes page/dashboard needs to be a bit stabler which is addressed by #168. as for next steps here: i would deploy sandbox killing from details for now to not be blocked by this and work through the other tasks at hand for now and implement killing from the list as soon as the sandboxes page / performance i much more predictable through the open pr.

@ben-fornefeld ben-fornefeld merged commit 643fefc into main Oct 30, 2025
5 checks passed
@ben-fornefeld ben-fornefeld deleted the feat/ability-to-kill-sandbox branch October 30, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants