-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for VNC using x11vnc and novnc #15
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
c8f0fd7
feat: add ubuntu-desktop template with custom wallpaper and vnc support
synacktraa c17d815
Cleanup dockerfile; create dev template
mlejva e7c84c2
Merge branch 'e2b-dev:main' into dev
synacktraa 0e08053
feat: restore original template directory
synacktraa 33f8d5f
feat: update env vars in desktop-dev template
synacktraa ff920e7
feat: add wait_for_port function to verify vnc and novnc status
synacktraa 07b8945
feat: full control over startup and vnc server
synacktraa 93ed2f2
feat: refresh desktop and unique password generation
synacktraa 4efffa6
fix: remove vnc and novnc handles on stop
synacktraa 47505a8
feat: add js sdk
synacktraa 5c299f9
feat: add auto-connect parameter in novnc URL
synacktraa 3524787
fix: resolve extended sandboxOpts issue
synacktraa 30a75a5
Merge branch 'js-sdk' into dev
synacktraa c53fdec
fix: resolve e2b wallpaper not applied issue
synacktraa 4dcae11
fix: catch command exit error in wait and verify method
synacktraa dfba7f8
Update README
jamesmurdza 0fb4544
feat: update the original template
synacktraa 280609c
Merge branch 'dev' of github.com:synacktraa/desktop into dev
synacktraa 5bdf00a
Merge branch 'e2b-dev:main' into dev
synacktraa d9db262
Revert changes made to template to add VNC support
jamesmurdza 483b807
Restore necessary changes to template for VNC support
jamesmurdza eea1159
Use E2B fork of noVNC without control bar and branding
jamesmurdza 070c494
Upgrade typedoc package to 0.27.9
jamesmurdza 7acd091
Add type definitions for NodeJS
jamesmurdza 869399a
Remove autoconnect parameter from examples
jamesmurdza 21c63dd
Add the password to the stream URL when auth is enabled
jamesmurdza d533660
Don't print the password in the Python example
jamesmurdza e4ac029
Enable stream auth in the TypeScript example
jamesmurdza 89c5795
Rename methods and documentation to use "stream" instead of "VNC"
jamesmurdza 64f77bf
Throw an error instead of returning null for getCursorPosition() and …
jamesmurdza 95d9072
Remove README for Python SDK
jamesmurdza 37e97c3
Remove desktop.hotkey()
jamesmurdza 0de885a
Rename takeScreenshot() to screenshot()
jamesmurdza b5bb082
Make password member private in the TypeScript SDK
jamesmurdza 34c9ccb
Throw an error on stream.start() if the stream is already running
jamesmurdza c5691f3
Always use Sandbox class name instead of Desktop
jamesmurdza 4103ecc
Move stream parameters to stream.start()
jamesmurdza 0288e85
Remove desktop.refresh()
jamesmurdza 6f45deb
added changeset
mishushakov a2b6e06
changed default sandbox template
mishushakov 4ce4632
Add apt-update
mlejva 787a4ab
Remove old streaming web page
mlejva 3e48c2f
Make sure to always pull the latest git repo in the sandbox template …
mlejva 71a06d8
Add readmes to each package
mlejva 684cde8
Explain better how stream auth works
mlejva db172e5
Remove example of customizing streaming port from readmes
mlejva 7a84ba9
Change positional params to an options object for the `write()` metho…
mlejva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@e2b/desktop-python": minor | ||
"@e2b/desktop": minor | ||
--- | ||
|
||
Added VNC support |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the examples up-to-date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Usage: #15 (comment)