Add the protogetter linter #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeebus
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
# Conflicts: # .golangci.yml
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
# Conflicts: # packages/api/internal/orchestrator/nodemanager/sandboxes.go
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
# Conflicts: # .golangci.yml # packages/api/internal/orchestrator/nodemanager/node.go # packages/api/internal/orchestrator/nodemanager/sandboxes.go # packages/api/internal/orchestrator/nodemanager/sync.go # packages/orchestrator/internal/template/server/create_template.go
ValentaTomas
approved these changes
Oct 6, 2025
# Conflicts: # packages/orchestrator/internal/server/sandboxes.go # packages/orchestrator/internal/template/server/create_template.go
Code42Cate
pushed a commit
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ghostiam/protogetter
Note
Enables the protogetter linter and replaces direct protobuf field access with Get* accessors across API, orchestrator, envd services, client-proxy, and tests.
protogetterin.golangci.yml.Get*methods inpackages/api(edge, nodemanager, placement, template-manager).packages/orchestrator(server, service, template build commands/phases, auth providers) to useGet*and adjust logging/metadata accordingly.packages/envdservices (filesystem, process) and legacy conversion toGet*accessors; update tests to use getters.packages/client-proxyorchestrator pool sync to getters.//nolint:protogetterwhere nil checks require direct access.Written by Cursor Bugbot for commit 04c006f. This will update automatically on new commits. Configure here.