Straighten out tracing #1235
Closed
Straighten out tracing #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/api/go.mod # packages/client-proxy/go.mod # packages/orchestrator/go.mod # packages/orchestrator/go.sum # packages/orchestrator/internal/sandbox/block/chunk.go # packages/orchestrator/internal/sandbox/build/cache.go # packages/orchestrator/internal/sandbox/checks.go # packages/orchestrator/internal/sandbox/nbd/dispatch.go # packages/orchestrator/internal/sandbox/nbd/path_direct.go # packages/orchestrator/internal/sandbox/rootfs/nbd.go # packages/orchestrator/internal/sandbox/sandbox.go # packages/orchestrator/internal/server/sandboxes.go # packages/shared/go.mod # packages/shared/pkg/storage/storage_fs.go # scripts/golang-dependencies-integrity.sh
# Conflicts: # packages/orchestrator/cmd/mock-nbd/mock.go # packages/orchestrator/internal/sandbox/block/tracker.go # packages/orchestrator/internal/sandbox/build/build.go # packages/orchestrator/internal/sandbox/build/cache_test.go # packages/orchestrator/internal/sandbox/nbd/dispatch.go # packages/orchestrator/internal/sandbox/sandbox.go # packages/orchestrator/internal/sandbox/uffd/handler.go
# Conflicts: # packages/orchestrator/internal/sandbox/build/build.go # packages/orchestrator/internal/sandbox/build/cache_test.go
djeebus
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Bug: Shared Context Causes Premature Cancellation
The ResumeSandbox function expects distinct contexts for setup/tracing and long-running operations. Passing the same context for both merges their lifecycle and cancellation behavior, which can lead to incorrect tracing and premature cancellation of sandbox operations.
packages/orchestrator/internal/template/build/layer/resume_sandbox.go#L32-L34
|
Cursor's point is probably invalid, but the code doesn't make it quite clear. The parallel spans probably need some refactoring to go with it, I'll give it a shot before we merge this. |
# Conflicts: # packages/orchestrator/internal/sandbox/build/cache_test.go # packages/orchestrator/internal/sandbox/sandbox.go # packages/shared/pkg/storage/storage_cache.go
# Conflicts: # packages/orchestrator/internal/sandbox/envd.go # packages/orchestrator/internal/sandbox/sandbox.go # packages/orchestrator/internal/sandbox/template/cache.go # packages/orchestrator/internal/sandbox/uffd/handler.go # packages/orchestrator/internal/server/sandboxes.go # packages/orchestrator/internal/template/build/layer/resume_sandbox.go
# Conflicts: # packages/orchestrator/internal/sandbox/envd.go
the conflicts aren't worth it
# Conflicts: # packages/orchestrator/internal/server/sandboxes.go
# Conflicts: # packages/orchestrator/go.mod # packages/orchestrator/internal/sandbox/template/cache.go # packages/shared/pkg/storage/storage_fs.go
|
Closing this until tracing is perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each sandbox creation will result in (up to) 3 traces:
This should help us break down where the time is being spent, and what it's doing.