-
Notifications
You must be signed in to change notification settings - Fork 175
Simplify sandbox store #1271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jakubno
wants to merge
11
commits into
main
Choose a base branch
from
simplify-sandbox-store
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Simplify sandbox store #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobrac
requested changes
Sep 30, 2025
Comment on lines
51
to
54
func WithIsExpired(isExpired bool) ItemsOption { | ||
return func(f *ItemsFilter) { | ||
f.IsExpired = &isExpired | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about making this false by default?
so.registration, err = so.meter.RegisterCallback( | ||
func(ctx context.Context, obs metric.Observer) error { | ||
sbxs := cache.Items(nil) | ||
sbxs := cache.Items(sandbox.WithState(sandbox.StateRunning), sandbox.WithIsExpired(false)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the WithIsExpired should be by default false
727887b
to
19ddf38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the sandbox store interface before we add redis store
Note
Reworks sandbox store to use option-based queries and atomic updates, refactoring orchestrator, handlers, metrics, analytics, and eviction to the new API.
Items(options...)
withItemsFilter
and helpers:WithTeamID
,WithAllTeams
,WithState
,WithStates
,WithOnlyExpired
.Update(sandboxID, updateFunc)
; removesItemsByState
,ItemsToEvict
,ExtendEndTime
from interface.NotFoundError
.Items
with filtering andUpdate
; removes old state-specific listing and TTL extension.applyFilter
and minor log tweak.GetSandboxes
now returns[]sandbox.Sandbox
and accepts store options.Items(WithAllTeams...)
and/or state filters.KeepAliveFor
now performs TTL changes viasandboxStore.Update
with explicit errors; updates orchestrator with new end time.Items(WithAllTeams(), WithOnlyExpired(true))
.GetSandboxes
API; split running/pausing via filtering; import shared utils for filtering.cache.Items(WithAllTeams())
for per-team counts.Written by Cursor Bugbot for commit 9f580dc. This will update automatically on new commits. Configure here.