Skip to content

Conversation

jakubno
Copy link
Member

@jakubno jakubno commented Sep 30, 2025

Note

Adds optional Cloud NAT for API nodes (with manual or auto static IPs), removes public IPs when enabled, and plumbs new variables through modules and Makefile.

  • Network (Terraform):
    • Add Cloud Router and Cloud NAT for API nodes in nomad-cluster/network/main.tf, with MANUAL_ONLY allocation using api_nat_ips or auto-created addresses.
    • Enable NAT logging (errors only) and create-before-destroy lifecycle; parameterize by gcp_region.
  • API Nodepool:
    • Make public IP assignment conditional in nomad-cluster/nodepool-api.tf (access_config removed when api_use_nat is true).
  • Variables & Wiring:
    • Introduce api_use_nat (bool) and api_nat_ips (list) in variables.tf at root, nomad-cluster/variables.tf, and nomad-cluster/network/variables.tf; pass through in main.tf and nomad-cluster/main.tf (including gcp_region to network module).
    • Expose new TF_VARs in iac/provider-gcp/Makefile.

Written by Cursor Bugbot for commit ec06289. This will update automatically on new commits. Configure here.

@jakubno jakubno added the improvement Improvement for current functionality label Sep 30, 2025
Copy link

linear bot commented Sep 30, 2025

@jakubno jakubno force-pushed the setup-nat-for-our-cluster-eng-2304 branch from 1f3944d to 9bf2143 Compare October 9, 2025 12:35
@jakubno jakubno marked this pull request as ready for review October 9, 2025 12:37
@jakubno jakubno requested a review from ValentaTomas as a code owner October 9, 2025 12:37
cursor[bot]

This comment was marked as outdated.

@jakubno jakubno force-pushed the setup-nat-for-our-cluster-eng-2304 branch from ed7949a to 62558f0 Compare October 9, 2025 13:34
@jakubno jakubno requested a review from dobrac October 9, 2025 13:35
cursor[bot]

This comment was marked as outdated.

@dobrac dobrac self-assigned this Oct 9, 2025
@jakubno jakubno merged commit 1578cca into main Oct 9, 2025
26 checks passed
@jakubno jakubno deleted the setup-nat-for-our-cluster-eng-2304 branch October 9, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement for current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants