Skip to content

Conversation

@djeebus
Copy link
Contributor

@djeebus djeebus commented Oct 31, 2025

Note

isHealthy now considers allocations with nil DeploymentStatus or nil Healthy as healthy; tests updated accordingly.

  • Orchestrator:
    • Update isHealthy in packages/api/internal/orchestrator/client.go to return true when DeploymentStatus is nil or Healthy is nil.
  • Tests:
    • Adjust expectations in packages/api/internal/orchestrator/client_test.go to reflect the new health evaluation behavior.

Written by Cursor Bugbot for commit fd97bb0. This will update automatically on new commits. Configure here.

@djeebus djeebus changed the title if allocation has no health, it is healthy If allocation has no health, it is healthy Oct 31, 2025
@djeebus djeebus added the bug Something isn't working label Oct 31, 2025
@ValentaTomas ValentaTomas marked this pull request as draft October 31, 2025 02:53
@ValentaTomas
Copy link
Member

@djeebus Is this superseded by #1392?

@djeebus
Copy link
Contributor Author

djeebus commented Nov 5, 2025

I think this is still a good fallback. It effectively changes the logic to "if the job has no defined health check, assume it's healthy", which matches what nomad would do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants