Skip to content

Conversation

0div
Copy link
Contributor

@0div 0div commented May 17, 2025

Description

virtio-rng front-end driver should already be compiled in in the kernel, based on the config.

this go code is equivalent to running:

curl --unix-socket $socket_location -i \
    -X PUT 'http://localhost/entropy' \
    -H 'Accept: application/json' \
    -H 'Content-Type: application/json' \
    -d "{
        \"rate_limiter\": {
            \"bandwidth\": {
                \"size\": 1000,
                \"one_time_burst\": 0,
                \"refill_time\": 100
            }
        }
    }"

Test

Spawn a sandbox and check the orchestrator logs for

2025-05-16 15:23:31.138 | stdout: 2025-05-16T22:23:31.138652154 [anonymous-instance:main] kick entropy rng.

Copy link

linear bot commented May 17, 2025

@0div 0div self-assigned this May 17, 2025
@0div 0div added the improvement Improvement for current functionality label May 17, 2025
@0div 0div marked this pull request as ready for review May 17, 2025 01:02
Copy link
Contributor

@dobrac dobrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you please add some integration tests for this or it's not possible?

@0div
Copy link
Contributor Author

0div commented May 19, 2025

Nice! Could you please add some integration tests for this or it's not possible?

I'm currently working on solving a code-interpreter same seed problem that will validate this or not.

Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you please add some integration tests for this or it's not possible?

I'm currently working on solving a code-interpreter same seed problem that will validate this or not.

The test should be here, otherwise it's possible to deploy broken version and find out too late

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement for current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants