Feature/integrate helm solver #2067
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…40 iterations with an index error.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2067 +/- ##
===========================================
- Coverage 78.86% 78.66% -0.21%
===========================================
Files 213 214 +1
Lines 26541 26634 +93
===========================================
+ Hits 20932 20952 +20
- Misses 5609 5682 +73 ☔ View full report in Codecov by Sentry. |
|
I think there should be more tests for this implementation |
|
Furthermore, documentation and CHANGELOG should be extended. |
|
still some bugs, for some networks results match, for others results don't match. I'm not sure why atm. Will investigate further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've created a PR which enables the use of the HELM method for pandapower. For this to function HELMPy needs to be installed. At the moment a modified Version must be used (this one here HELMPy), this version returns more values, for example if the method did converge and how many pade approximations needed to be done to reach the target accuracy.
BR