fix(menu): changed icon--tick-16 to be icon--16

eBay · Jul 2, 2024 · bfa7be4 · bfa7be4
1 parent a565a3b
commit bfa7be4
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 28 deletions.
diff --git a/.changeset/mighty-cycles-drive.md b/.changeset/mighty-cycles-drive.md
@@ -0,0 +1,5 @@
+---
+"@ebay/skin": patch
+---
+
+menu/menu-button: changed icon--tick-16 to be icon--16
diff --git a/dist/menu-button/menu-button.css b/dist/menu-button/menu-button.css
diff --git a/dist/menu/menu.css b/dist/menu/menu.css
diff --git a/src/sass/menu-button/menu-button.scss b/src/sass/menu-button/menu-button.scss
@@ -42,13 +42,13 @@ div.menu-button__item[role^="menuitem"] {
     cursor: default; /* needed to override text cursor */
 }
 
-.menu-button__item svg.icon--tick-16,
-.fake-menu-button__item svg.icon--tick-16 {
+.menu-button__item svg.icon--16,
+.fake-menu-button__item svg.icon--16 {
     @include menu-menuitem-status();
 }
 
-.menu-button__item svg.icon--tick-16:last-child,
-.fake-menu-button__item svg.icon--tick-16:last-child {
+.menu-button__item svg.icon--16:last-child,
+.fake-menu-button__item svg.icon--16:last-child {
     margin-left: var(--spacing-100);
 }
 
@@ -87,12 +87,12 @@ button.fake-menu-button__item {
     text-align: left;
 }
 
-a.fake-menu-button__item[aria-current="page"] svg.icon--tick-16,
-button.fake-menu-button__item[aria-current="page"] svg.icon--tick-16 {
+a.fake-menu-button__item[aria-current="page"] svg.icon--16,
+button.fake-menu-button__item[aria-current="page"] svg.icon--16 {
     opacity: 1;
 }
 
-div.menu-button__item[role^="menuitem"][aria-checked="true"] svg.icon--tick-16 {
+div.menu-button__item[role^="menuitem"][aria-checked="true"] svg.icon--16 {
     opacity: 1;
 }
 

diff --git a/src/sass/menu/menu.scss b/src/sass/menu/menu.scss
@@ -30,13 +30,13 @@ span.fake-menu__items {
     padding: 0;
 }
 
-.menu__item > svg.icon--tick-16,
-.fake-menu__item > svg.icon--tick-16 {
+.menu__item > svg.icon--16,
+.fake-menu__item > svg.icon--16 {
     @include menu-menuitem-status();
 }
 
-.menu__item > svg.icon--tick-16:last-child,
-.fake-menu__item > svg.icon--tick-16:last-child,
+.menu__item > svg.icon--16:last-child,
+.fake-menu__item > svg.icon--16:last-child,
 .fake-menu__item .badge,
 .menu__item .badge {
     margin-left: var(--spacing-100);
@@ -63,8 +63,8 @@ a.fake-menu__item:focus {
     text-decoration: underline;
 }
 
-a.fake-menu__item[aria-current="page"] svg.icon--tick-16,
-button.fake-menu__item[aria-current="page"] svg.icon--tick-16 {
+a.fake-menu__item[aria-current="page"] svg.icon--16,
+button.fake-menu__item[aria-current="page"] svg.icon--16 {
     opacity: 1;
 }
 
@@ -80,7 +80,7 @@ div.menu__item[role^="menuitem"][aria-disabled="true"] {
     font-weight: unset;
 }
 
-div.menu__item[role^="menuitem"][aria-checked="true"] svg.icon--tick-16 {
+div.menu__item[role^="menuitem"][aria-checked="true"] svg.icon--16 {
     opacity: 1;
 }