Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually fix a set of Topic QoS, and implement the max-tx-rate, max-rx-rate, and downsampling #64

Merged
merged 41 commits into from
Nov 7, 2023
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
767afd5
Max-reception-rate & downsampling in RTPS participants
Tempate Oct 2, 2023
41639fa
Max-reception-rate & downsampling in DDS participants
Tempate Oct 2, 2023
2414719
Rename max-reception-rate to max-rx-rate
Tempate Oct 4, 2023
eba59e2
Basic support for manual topics tag
Tempate Oct 4, 2023
3d7aa54
Read all TopicQoS in the manual topics
Tempate Oct 5, 2023
d86f91e
Implement max transmission rate
Tempate Oct 5, 2023
7394ef2
Minor fixes
Tempate Oct 5, 2023
48b7deb
Fix bugs and clean code
Tempate Oct 6, 2023
061dead
Fix rebase error
Tempate Oct 9, 2023
a3e9f68
Make the DdsPipeConfiguration required
Tempate Oct 10, 2023
030f41d
Apply manual topics by default to all participants
Tempate Oct 10, 2023
115d282
Remove Wildcard Topic without name test
Tempate Oct 10, 2023
6096e9f
Simplify the DdsPipe's constructor
Tempate Oct 10, 2023
2912be3
Minor fixes
Tempate Oct 11, 2023
6678aba
Support on_data_available with multiple messages
Tempate Oct 16, 2023
ac8b5b6
Uncrustify
Tempate Oct 17, 2023
61d1a46
Fix compilation in Ubuntu 20.04 debug
Tempate Oct 17, 2023
3b30130
Support manual topics in the dds participant
Tempate Oct 17, 2023
ad4a249
Uncrustify
Tempate Oct 17, 2023
6e3353e
Minor fixes
Tempate Oct 17, 2023
fd7839f
Fix bug customizing a topic in the DdsBridge
Tempate Oct 18, 2023
0bdb91f
Apply suggestions
Tempate Oct 18, 2023
aef399c
Avoid using DdsTopics in the DdsBridge
Tempate Oct 19, 2023
55dc7bc
Minor fixes
Tempate Oct 19, 2023
44fa4c8
Add Topic QoS to the SchemaParticipant
Tempate Oct 19, 2023
268e148
Bugfix copy method
Tempate Oct 19, 2023
2f78320
Uncrustify & Windows fix
Tempate Oct 19, 2023
24e5c49
Allowed topics test
Tempate Oct 19, 2023
7fedb4a
Pack the QoSs in specs on a Topic QoS object
Tempate Oct 20, 2023
3e5a5e0
Fix default Topic QoS variable
Tempate Oct 23, 2023
f4ddf38
Apply suggestions
Tempate Oct 23, 2023
ad29663
Rename max-depth to history-depth
Tempate Oct 23, 2023
9c64eda
Uncrustify
Tempate Oct 23, 2023
ad75b36
Remove test that checks parsing QoS in a DdsTopic
Tempate Oct 23, 2023
3d7e898
Fix compilation in Ubuntu 20.04 debug
Tempate Oct 23, 2023
c72b5ec
Improve test according to suggestion
Tempate Oct 24, 2023
ef730a7
Apply specs TopicQoS over discovery TopicQoS
Tempate Oct 25, 2023
e13ca48
Apply suggestions
Tempate Oct 30, 2023
1f9a662
Apply suggestions
Tempate Nov 2, 2023
b9d2c47
Apply more suggestions
Tempate Nov 6, 2023
0c5fff5
Add missing Windows header
Tempate Nov 7, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Uncrustify & Windows fix
Signed-off-by: tempate <danieldiaz@eprosima.com>
Tempate committed Nov 6, 2023
commit 2f78320aedfce96166393a7023acb3b42d587277
2 changes: 1 addition & 1 deletion ddspipe_core/include/ddspipe_core/types/topic/Topic.hpp
Original file line number Diff line number Diff line change
@@ -64,7 +64,7 @@ struct Topic : public ITopic, public IConfiguration
const ITopic& other) const noexcept override;

DDSPIPE_CORE_DllAPI
virtual Topic& operator = (
virtual Topic& operator =(
const Topic& other) noexcept;

/////////////////////////
Original file line number Diff line number Diff line change
@@ -46,8 +46,9 @@ struct DdsTopic : public DistributedTopic
// OPERATORS
/////////////////////////

virtual DdsTopic& operator = (
const DdsTopic& other) noexcept;
DDSPIPE_CORE_DllAPI
virtual DdsTopic& operator =(
const DdsTopic& other) noexcept;

/////////////////////////
// METHODS
2 changes: 1 addition & 1 deletion ddspipe_core/src/cpp/types/topic/dds/DdsTopic.cpp
Original file line number Diff line number Diff line change
@@ -118,7 +118,7 @@ bool DdsTopic::is_valid_dds_topic(
DdsTopic& DdsTopic::operator = (
const DdsTopic& other) noexcept
{
Topic::operator=(other);
Topic::operator =(other);

this->type_name = other.type_name;