Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20334] Report internal DdsRouter information with the DdsPipe's Monitor module #431

Merged
merged 17 commits into from
Mar 19, 2024

Conversation

Tempate
Copy link
Contributor

@Tempate Tempate commented Feb 12, 2024

In this version, the DdsRouter makes use of the DdsPipe's Monitor module to report information about its topics.

Merge after:

Signed-off-by: tempate <[email protected]>
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 30.41%. Comparing base (29de75f) to head (ac92f9b).

Files Patch % Lines
tools/ddsrouter_tool/src/cpp/main.cpp 0.00% 1 Missing and 3 partials ⚠️
...dsrouter_yaml/src/cpp/YamlReader_configuration.cpp 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   30.74%   30.41%   -0.33%     
==========================================
  Files          16       16              
  Lines         553      559       +6     
  Branches      291      297       +6     
==========================================
  Hits          170      170              
- Misses        200      202       +2     
- Partials      183      187       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15 rsanchez15 merged commit 4506ad3 into main Mar 19, 2024
26 of 30 checks passed
@rsanchez15 rsanchez15 deleted the feature/monitor branch March 19, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants