Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22427] Fast DDS EASY_MODE - Feature - XMLRPC Server #1020

Merged
merged 11 commits into from
Jan 23, 2025
Merged

[22427] Fast DDS EASY_MODE - Feature - XMLRPC Server #1020

merged 11 commits into from
Jan 23, 2025

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Jan 17, 2025 •
edited
Loading

Description

This PR updates documentation about the new Easy Mode feature.

Must merge after:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@cferreiragonz cferreiragonz added this to the v3.2.0 milestone Jan 17, 2025
@Mario-DL Mario-DL mentioned this pull request Jan 17, 2025
Merged
Mario-DL
Mario-DL requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation changes.
Leaving some suggestions though

@cferreiragonz cferreiragonz mentioned this pull request Jan 20, 2025
Merged
13 tasks
@Mario-DL Mario-DL self-requested a review January 20, 2025 15:28
@cferreiragonz
Refs #22627: Review - NIT
0ce51e5 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz cferreiragonz force-pushed the feature/fastdds-impl/auto_ds_daemonized branch from 4fa05b6 to 0ce51e5 Compare January 20, 2025 16:05
Mario-DL
Mario-DL previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

rsanchez15
rsanchez15 requested changes Jan 22, 2025
View reviewed changes
rsanchez15
rsanchez15 previously approved these changes Jan 22, 2025
View reviewed changes
@cferreiragonz cferreiragonz force-pushed the feature/fastdds-impl/auto_ds_daemonized branch from 02929f4 to f6992d1 Compare January 22, 2025 14:49
@cferreiragonz cferreiragonz force-pushed the feature/fastdds-impl/auto_ds_daemonized branch from f6992d1 to a72b80e Compare January 22, 2025 16:01
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima January 22, 2025 16:02
@cferreiragonz @Mario-DL
Refs #22627: Revision - Change Link
2db4587 
Co-authored-by: Mario Domínguez López <[email protected]>
Signed-off-by: Carlos Ferreira González <[email protected]>
Mario-DL
Mario-DL approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL Mario-DL merged commit 8e9a8da into master Jan 23, 2025
4 checks passed
@Mario-DL Mario-DL deleted the feature/fastdds-impl/auto_ds_daemonized branch January 23, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany left review comments

@Mario-DL Mario-DL Mario-DL approved these changes

@rsanchez15 rsanchez15 rsanchez15 left review comments

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v3.2.0 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
4 participants
@cferreiragonz @rsanchez15 @MiguelCompany @Mario-DL