Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app_id and app_metadata attributes #59

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Conversation

jepemi
Copy link
Contributor

@jepemi jepemi commented Nov 3, 2023

Store app_id and app_metadata attributes in Fast DDS Spy participants.

Merge after:

@jepemi jepemi changed the title Feature/app id metadata app_id and app_metadata attributes Nov 3, 2023
@jepemi jepemi changed the title app_id and app_metadata attributes Add app_id and app_metadata attributes Nov 6, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ca02f5c) 65.44% compared to head (89b25e5) 65.02%.

Files Patch % Lines
...astddsspy_yaml/src/cpp/YamlReaderConfiguration.cpp 0.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   65.44%   65.02%   -0.43%     
==========================================
  Files          22       22              
  Lines        1094     1098       +4     
  Branches      381      385       +4     
==========================================
- Hits          716      714       -2     
- Misses        136      137       +1     
- Partials      242      247       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jesus Perez <[email protected]>
Signed-off-by: Jesus Perez <[email protected]>
Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irenebm irenebm merged commit 26f4bb2 into main Nov 17, 2023
@irenebm irenebm deleted the feature/app_id_metadata branch November 17, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants