Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19974] Update problems' status to be treated as warnings instead of errors #212

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

jepemi
Copy link
Contributor

@jepemi jepemi commented Nov 23, 2023

Update problems' status to be treated as warnings instead of errors

  • Logic
  • Tests
  • Doc

Merge after:

Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncrustify

irenebm
irenebm previously approved these changes Nov 27, 2023
Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@jepemi jepemi force-pushed the feature/monitor_service_status_topic branch from 6631899 to a9007ab Compare December 5, 2023 15:56
@jepemi jepemi force-pushed the hotfix/status_warnings branch from 5e2ab93 to 4263dd3 Compare December 11, 2023 10:29
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dc99fec) 58.20% compared to head (3e87670) 58.20%.

Files Patch % Lines
src/cpp/database/database.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   58.20%   58.20%           
=======================================
  Files          40       40           
  Lines        5678     5678           
  Branches     2989     2989           
=======================================
  Hits         3305     3305           
  Misses         88       88           
  Partials     2285     2285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jepemi jepemi force-pushed the feature/monitor_service_status_topic branch 7 times, most recently from 080fbe7 to 617140c Compare December 18, 2023 10:25
@jepemi jepemi force-pushed the hotfix/status_warnings branch from 4263dd3 to 70a6e35 Compare December 18, 2023 10:40
Base automatically changed from feature/monitor_service_status_topic to main December 18, 2023 13:31
@rsanchez15 rsanchez15 dismissed irenebm’s stale review December 18, 2023 13:31

The base branch was changed.

Copy link
Contributor

@irenebm irenebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@jepemi jepemi merged commit f8fb83f into main Dec 18, 2023
12 checks passed
@jepemi jepemi deleted the hotfix/status_warnings branch December 18, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants