-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19865] Add app_id to monitor participant #217
Conversation
525e415
to
20b3df9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the very least, add this change to the InitMonitorTests tests
4263dd3
to
70a6e35
Compare
0fdf10a
to
6e0de3c
Compare
ed1d34a
to
3e87670
Compare
6e0de3c
to
25f3c18
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
==========================================
- Coverage 58.20% 58.16% -0.05%
==========================================
Files 40 40
Lines 5678 5682 +4
Branches 2989 2993 +4
==========================================
Hits 3305 3305
Misses 88 88
- Partials 2285 2289 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jesus Perez <[email protected]>
Signed-off-by: Jesus Perez <[email protected]>
25f3c18
to
a9bfe7d
Compare
Signed-off-by: Jesus Perez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jesus Perez <[email protected]>
Signed-off-by: Jesus Perez <[email protected]>
Add two new arguments to
init_monitor()
methods to setapp_id
andapp_metadata
discovery properties. Default values are"UNKNOWN_APP"
and an empty string respectively.