Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22706] Warn about XTypes in Fast DDS v3 #5601

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Jan 28, 2025

Description

This PR adds a warning in the migration guide to Fast DDS v3 about XTypes.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@rsanchez15 rsanchez15 merged commit 9ddad46 into master Jan 28, 2025
3 checks passed
@rsanchez15 rsanchez15 deleted the warn_about_xtypes branch January 28, 2025 10:48
@rsanchez15
Copy link
Contributor

@Mergifyio backport 3.1.x 3.0.x

Copy link
Contributor

mergify bot commented Jan 28, 2025

backport 3.1.x 3.0.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants