Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release for v 1.3.2 #132

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Prepare release for v 1.3.2 #132

merged 5 commits into from
Dec 13, 2022

Conversation

bvreede
Copy link
Contributor

@bvreede bvreede commented Dec 12, 2022

Picks up the new release with new contributor @malininae from #123;
Closes #127

Copy link
Member

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just two small comments from me! 😄

.github/workflows/test_codecov.yml Outdated Show resolved Hide resolved
@@ -1,6 +1,12 @@
Release Notes
*************

1.3.2 (2021-12-13)
~~~~~~~~~~~~~~~~~~
* Elaborate the range of years that can be queried `#123 <https://github.com/eWaterCycle/era5cli/pull/123>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Elaborate the range of years that can be queried `#123 <https://github.com/eWaterCycle/era5cli/pull/123>`_
* Extend the range of years that can be queried `#123 <https://github.com/eWaterCycle/era5cli/pull/123>`_

Would it be nice to have a link here to an ECMWF post explaining the back extension years?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it would be! Unfortunately I couldn't find one. I found an email, but no online version of the same message... Instead of searching further, I'ma push on with the release ;)

Co-authored-by: Bart Schilperoort <[email protected]>
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@2b8e449). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage        ?   99.00%           
=======================================
  Files           ?        7           
  Lines           ?      402           
  Branches        ?        0           
=======================================
  Hits            ?      398           
  Misses          ?        4           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b8e449...39cb816. Read the comment docs.

@bvreede bvreede merged commit 3fcbe8e into main Dec 13, 2022
@bvreede bvreede deleted the prep-release-v1.3.2 branch December 13, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update python versions in CI
2 participants