Add support for ERA5-land #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 98.06% 98.20% +0.14%
==========================================
Files 7 7
Lines 310 335 +25
==========================================
+ Hits 304 329 +25
Misses 6 6
Continue to review full report at Codecov.
|
nielsdrost
requested changes
Feb 19, 2021
There was a problem hiding this comment.
Nice work @bvreede and @Peter9192 !
A few small comments, otherwise good to go :-)
nielsdrost
approved these changes
Feb 19, 2021
|
Thanks @bvreede and @Peter9192! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds functionality for downloading the ERA5-land datasets (hourly and monthly). For example:
will list all the available variables in the land data, and
will print the request for 2008 monthly snow cover data (remove the dry run to actually download the data).
Documentation has been added, as well as several new checks and tests. As the number of input parameters grows, we believe it would be useful to comprehensively check the compatibility of all the available options. We opened a new issue to address this (#68).
closes #54