-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add functionality for download of subregion #70
Merged
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
eb10afe
Subregion selection
aytacpacal 352404f
Modified README
aytacpacal 5ef8069
Modified README
aytacpacal 15b0e49
merge updated land support to subregion branch
bvreede 08bd892
Apply PR66 review corrections to parse area coordinates
bvreede a5db94f
parse and verify area coordinates
bvreede a4f99ca
Test cli input for area coordinates
bvreede e07db17
Match cli and fetch documentation
bvreede f017b65
add area to filename
bvreede 37018e2
change error to satisfy flake8
bvreede 57024b8
add test for area coords in outputfilename
bvreede 496959b
Error is a system exithttps://stackoverflow.com/questions/14728376/i-…
bvreede 64897ca
Update era5cli/fetch.py
bvreede 865852f
fix merge conflicts
bvreede eee0211
adjust readme description
bvreede b6d2e45
remove coordinate confusion and use xmax xmin ymax ymin consistently
bvreede 5119c24
Update tests/test_fetch.py
bvreede 4d3d0ca
Update tests/test_cli.py
bvreede 7b2afb4
Update tests/test_cli.py
bvreede dce63fb
Update tests/test_cli.py
bvreede 87ddf8e
changed output filename to include coordinates with NSEW notation
bvreede c961d1c
fix spaces for flake8
bvreede aec813a
add N/E to 0 coordinate in name
bvreede File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beware that
round(1.5) = 2
whileint(1.5)=1
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks muchly! Incorporated.
Questions (to pay attention to in the new commit):
I liked having a direct relationship between the user input and the file name; that is the only thing I'm sad to lose...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done 👍 . I think I'd prefer 0N and 0E over just plain zeros.