fix: use correct path concatenation

eWert-Online · Apr 20, 2024 · 7640fcd · 7640fcd
1 parent 40b1ed9
commit 7640fcd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/OSnap.ml b/lib/OSnap.ml
@@ -29,7 +29,7 @@ let setup ~noCreate ~noOnly ~noSkip ~parallelism ~config_path =
       |> Lwt_list.map_p_until_exception (fun size ->
         let { name = _size_name; width; height } = size in
         let filename = Test.get_filename test.name width height in
-        let current_image_path = snapshot_dir ^ filename in
+        let current_image_path = Filename.concat snapshot_dir filename in
         let exists = Sys.file_exists current_image_path in
         if noCreate && not exists
         then

diff --git a/lib/OSnap_Browser/OSnap_Browser_Path.ml b/lib/OSnap_Browser/OSnap_Browser_Path.ml
@@ -4,7 +4,7 @@ let revision_to_string revision = revision
 let revisions = [ "1289146"; "1056772"; "961656"; "960312"; "884014"; "856583" ]
 let get_latest_revision () = List.hd revisions
 let get_previous_revisions () = List.tl revisions
-let get_folder_name revision = "osnap_chromium_" ^ revision
+let get_folder_name revision = Printf.sprintf "osnap_chromium_%s" revision
 
 let get_chromium_path revision =
   match Sys.getenv_opt "HOME" with

diff --git a/lib/OSnap_Utils/OSnap_Utils.ml b/lib/OSnap_Utils/OSnap_Utils.ml
@@ -71,7 +71,7 @@ let path_of_segments paths =
        (fun acc curr ->
          match acc with
          | "" -> curr
-         | path -> path ^ "/" ^ curr)
+         | path -> Filename.concat path curr)
        ""
 ;;