Document icon.png #843
Document icon.png #843
Conversation
The EXPath Package spec does not mention icon.png, but if the eXist-db Dashboard finds an image resource with a filename beginning with the string "icon" in the root directory of an app, it will display that instead of the default eXist-db blue dotted "X". See https://markmail.org/message/5m6fjqso4m4veuos
|
@djbpitt I was under the impression it had to be named |
|
@adamretter I did not test it with values other than |
|
In 2014 @christophe-g added support for icon.svg. The code that displays icons now lives in https://github.com/eXist-db/existdb-packageservice/blob/master/modules/get-icon.xql - but support remains limited to png and svg. @djbpitt We had a similar conversation in eXist-db/dashboard#178. |
| <para>The following is not mentioned in the EXPath spec, but if an image resource with a | ||
| name that begins with the string <literal>icon</literal> is found in the root directory | ||
| of an app, the eXist-db dashboard will display that user-supplied image instead of the | ||
| default eXist-db blue dotted <literal>X</literal>.</para> |
There was a problem hiding this comment.
@djbpitt These are the lines containing the new contribution, correct? I just want to be sure I didn't miss anything in the other changes, which upon first glance appear to be whitespace-only.
There was a problem hiding this comment.
@joewiz Yes. The whitespace changes are a side-effect of pretty-printing in <oXygen/>. Should I have known of an easy way to exclude them from the commit? They certainly do make it harder to understand.
There was a problem hiding this comment.
@djbpitt No worries. To avoid this on repositories that don't have a coordinated whitespace policy, I apply format & indent to the element(s) I've edited instead of to the whole document. Right click on an element and from the contextual menu select Source > Format and Indent Element. Or from the menu bad select Document > Source > Format and Indent Element.
There was a problem hiding this comment.
@joewiz Got it. Thank you. Another day, another feature I hadn’t known about …
There was a problem hiding this comment.
see #637 running mvn clean package or mvn test will enforce a unified linting of all xml files.
|
@djbpitt i think this is a great contribution. Thank for your time. Maybe just add that it is for. Svg or. Png |
|
@adamretter Done! Thank you! |
The EXPath Package spec does not mention icon.png, but if the eXist-db Dashboard finds an image resource with a filename beginning with the string "icon" in the root directory of an app, it will display that instead of the default eXist-db blue dotted "X". See https://markmail.org/message/5m6fjqso4m4veuos