Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now catching 'LinAlgErrors' in '.fit' method #94

Merged
merged 4 commits into from
Jul 2, 2020

Conversation

FelSiq
Copy link
Collaborator

@FelSiq FelSiq commented May 26, 2020

Resolves #92, partially.

Changes

  • Catching an unified set of exceptions in pre-computations, extraction and post-computations. In particular, now pre-computations will not crash when a np.linalg.LinAlgError is raised.

Still up to discussion

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #94 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   98.85%   98.93%   +0.07%     
==========================================
  Files          15       15              
  Lines        2187     2528     +341     
==========================================
+ Hits         2162     2501     +339     
- Misses         25       27       +2     
Impacted Files Coverage Δ
pymfe/complexity.py 99.61% <ø> (-0.39%) ⬇️
pymfe/info_theory.py 99.01% <ø> (ø)
pymfe/_internal.py 97.40% <100.00%> (+0.03%) ⬆️
pymfe/_utils.py 100.00% <100.00%> (ø)
pymfe/mfe.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a0fc8...69b729f. Read the comment docs.

@FelSiq FelSiq marked this pull request as ready for review July 1, 2020 21:42
Copy link
Owner

@ealcobaca ealcobaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Felipe, we can find other errors that can be caught to increase the '_EXCEPTIONS' list later :)

@ealcobaca ealcobaca merged commit 886c48d into master Jul 2, 2020
@FelSiq FelSiq deleted the precomp-lin-alg-err branch July 2, 2020 04:42
ealcobaca added a commit that referenced this pull request Jul 2, 2020
Now catching 'LinAlgErrors' in '.fit' method
ealcobaca added a commit that referenced this pull request Jul 2, 2020
Now catching 'LinAlgErrors' in '.fit' method
ealcobaca added a commit that referenced this pull request Jul 3, 2020
Now catching 'LinAlgErrors' in '.fit' method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numpy.linalg.LinAlgError: SVD did not converge
2 participants