fix: allow multiple base58 address sizes#45
Open
fboucquez wants to merge 3 commits intoealmansi:masterfrom
Open
fix: allow multiple base58 address sizes#45fboucquez wants to merge 3 commits intoealmansi:masterfrom
fboucquez wants to merge 3 commits intoealmansi:masterfrom
Conversation
fboucquez
commented
Sep 9, 2024
| '3NKpWcnyZtEKttoQECAFTnmkxMkzgbT4WX', | ||
| '3Dq1CBvAbQ5AxGCNT4byE8PhNQExZcR6Q2' | ||
| '3Dq1CBvAbQ5AxGCNT4byE8PhNQExZcR6Q2', | ||
| 'BfdrC5aVm7A9YcSQnwxWWXjXGSxwgUdMmA7goREBawA8SHtUcp' |
Author
There was a problem hiding this comment.
this could be problematic, some addresses are detected as p2sh, some as p2pkh
Author
|
I cannot build atm on my mac, I haven't updated the dist folder |
Author
|
I've manged to re-build downgrading to v16.20.0, but the changes are way more than they should. @ealmansi , what node version did you use? |
0c8e6ca to
602fbda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It relaxes the base58 validation to allow extended sizes according to this doc
In particular, we encountered issues with this address that started the investigation.
closes: #44
cc @ealmansi